Expand active page when it has subpages on modern template#8896
Merged
yufeih merged 1 commit intodotnet:mainfrom Jun 21, 2023
MihkelAuv:expand-page-with-subpages
Merged
Expand active page when it has subpages on modern template#8896yufeih merged 1 commit intodotnet:mainfrom MihkelAuv:expand-page-with-subpages
yufeih merged 1 commit intodotnet:mainfrom
MihkelAuv:expand-page-with-subpages
Conversation
yufeih
approved these changes
Jun 21, 2023
Contributor
yufeih
left a comment
yufeih
left a comment
There was a problem hiding this comment.
Thank you @MihkelAuv ! The change looks good.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #8896 +/- ##
==========================================
- Coverage 77.00% 76.99% -0.01%
==========================================
Files 605 605
Lines 25036 25036
==========================================
- Hits 19278 19277 -1
- Misses 5758 5759 +1 ☔ View full report in Codecov by Sentry. |
yufeih
added
the
new-feature
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default template expands its contents in the table of contents (TOC) when the current page has subpages, but the modern template currently does not.
This PR adds an additional check to the modern template to verify whether the currently active page has subpages and expands them.